feat(openAPI-union) Add type support for unions with additionalProperties to provide ts intellisense #2415
+140
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 404db56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
remy90
changed the title
remy90
changed the title
Author
Contributor
|
Thanks for submitting this! Sorry for the delay in reviewing. There’s a slight conflict with another PR that recently got merged. If you’re able to resolve the conflict, and tests are still passing, would be happy to merge, thank you! Also please be sure to add a changeset (see comment) so this can be versioned & released |
Author
|
Hey @drwpow, Thanks again, |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your work on this package, much appreciated! I came across
string & {}recently to get 'loose autocomplete' on a string and thought it might help here.Changes
What does this PR change? Link to any related issue(s).
A union of type "A" | "B" | "C" will now provide intellisense options from the union but also accept non-union string entries
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)